Skip to content

Add git version check for overlay analysis enablement #3370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 22 commits into from
Dec 18, 2025
Merged

Add git version check for overlay analysis enablement #3370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
aff7998
Initial plan
Copilot Dec 16, 2025
89753aa
Add git version check for overlay analysis enablement
Copilot Dec 16, 2025
fc2bbb0
Address code review feedback
Copilot Dec 16, 2025
c3dc529
Address feedback: cache git version, improve error handling, add tele…
Copilot Dec 16, 2025
393c074
Refactor existing telemetry diagnostics to use makeTelemetryDiagnostic
Copilot Dec 16, 2025
32795b3
Merge branch 'main' into copilot/update-overlay-git-version-check
henrymercer Dec 17, 2025
e052dbd
Remove caching mechanism
henrymercer Dec 17, 2025
3765106
Move git version logging to config utils
henrymercer Dec 17, 2025
9c5588d
Remove unnecessary stub restores
henrymercer Dec 17, 2025
056581e
Update `makeTelemetryDiagnostic` doc
henrymercer Dec 17, 2025
a13b404
Record both truncated and full git versions
henrymercer Dec 17, 2025
a2c3c8e
Bump log level for failing to parse git version
henrymercer Dec 17, 2025
003ddae
Avoid non-determinism in PR checks due to overlay FFs
henrymercer Dec 18, 2025
358a55e
Throw in test mode if can't compute git version
henrymercer Dec 18, 2025
cec3cc5
Trim git version output
henrymercer Dec 18, 2025
948c7fb
Test mode: Tolerate missing git binary
henrymercer Dec 18, 2025
ff84c6f
Improve comment
henrymercer Dec 18, 2025
a7e88a4
Only enable overlay for the code scanning suite
henrymercer Dec 18, 2025
95246ce
Prefer explicit env var to binary accessibility check
henrymercer Dec 18, 2025
034401b
Merge branch 'main' into copilot/update-overlay-git-version-check
henrymercer Dec 18, 2025
8b428c0
Use `EnvVar`
henrymercer Dec 18, 2025
3b6fef6
Fix import order
henrymercer Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/__global-proxy.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions .github/workflows/codescanning-config-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ env:
# Diff informed queries add an additional query filter which is not yet
# taken into account by these tests.
CODEQL_ACTION_DIFF_INFORMED_QUERIES: false
# Specify overlay enablement manually to ensure stability around the exclude-from-incremental
# query filter. Here we only enable for the default code scanning suite.
CODEQL_ACTION_OVERLAY_ANALYSIS: true
CODEQL_ACTION_OVERLAY_ANALYSIS_JAVASCRIPT: false
CODEQL_ACTION_OVERLAY_ANALYSIS_CODE_SCANNING_JAVASCRIPT: true

on:
push:
Expand Down
Loading
Loading