-
Notifications
You must be signed in to change notification settings - Fork 430
Add an explicit deprecation date #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/actions-util.ts
Outdated
| MismatchedBranches: `Please make sure that every branch in on.pull_request is also in on.push so that Code Scanning can compare pull requests against the state of the base branch.`, | ||
| MissingHooks: `Please specify on.push and on.pull_request hooks so that Code Scanning can compare pull requests against the state of the base branch.`, | ||
| MissingPullRequestHook: `Please specify an on.pull_request hook so that Code Scanning is run against pull requests.`, | ||
| MissingPullRequestHook: `Please specify an on.pull_request hook so that Code Scanning is explicitly run against pull requests. This will be required to see results on pull requests from 2021-01-31.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be more or less inclusive to spell out the date in words? Though people should realise the format when they try to work out what the 31st month is...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It crossed my mind. I think that's a good suggestion. How about 31 January 2021?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. That looks much less ambiguous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
ca89934 to
15c4618
Compare
robertbrignull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
So that we can remove support for the beta configuration of `on: push`-only we should communicate a date after which this will not work.
15c4618 to
8e0e34a
Compare
So that we can remove support for the beta configuration of
on: push-only we should communicate a date after which thiswill not work.
Merge / deployment checklist