Add a query to detect binary planting vulnerabilities. #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Query looks correct to me. Do you have a link to a test? Perhaps temporarily introduce a vulnerability in this PR or on another branch and we'll check the query finds it. |
Contributor
Author
|
Sure @robertbrignull. I've opened #315 which reverts the fixes made in #309 to show that it finds the original issues. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a query to detect new instances of the problem fixed in #309, by looking for any unqualified binary names (e.g.
"git") being executed without being passed throughsafeWhich.Merge / deployment checklist