Skip to content

Update code so "no-shadow" passes #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisgavin merged 11 commits into from
Nov 20, 2020
Merged

Update code so "no-shadow" passes #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
22f779c
Update ESLint configuration
ericcornelissen Nov 19, 2020
b54c2aa
Fix no shadow issues in api-client.ts
ericcornelissen Nov 19, 2020
98ad63b
Fix no shadow issues in codeql.ts
ericcornelissen Nov 19, 2020
06e99f1
Fix no shadow issues in config-utils.test.ts
ericcornelissen Nov 19, 2020
2a2910e
Fix no shadow issues in config-utils.ts
ericcornelissen Nov 19, 2020
ffe9468
Fix no shadow issues in fingerprints.test.ts
ericcornelissen Nov 19, 2020
7455994
Fix no shadow issues in fingerprints.ts
ericcornelissen Nov 19, 2020
483c94b
Fix no shadow issues in upload-lib.ts
ericcornelissen Nov 19, 2020
847f4ef
Run npm run build
ericcornelissen Nov 19, 2020
992a0cf
Merge branch 'main' into eslint-rule/no-shadow
ericcornelissen Nov 19, 2020
7091b81
Merge branch 'main' into eslint-rule/no-shadow
chrisgavin Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
"no-async-foreach/no-async-foreach": "error",
"no-console": "off",
"no-sequences": "error",
"no-shadow": "off",
"@typescript-eslint/no-shadow": ["error"],
"one-var": ["error", "never"]
},
"overrides": [{
Expand All @@ -48,8 +50,7 @@
"@typescript-eslint/require-await": "off",
"@typescript-eslint/restrict-template-expressions": "off",
"func-style": "off",
"github/no-then": "off",
"no-shadow": "off"
"github/no-then": "off"
}
}]
}
2 changes: 1 addition & 1 deletion lib/api-client.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/api-client.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

54 changes: 27 additions & 27 deletions lib/codeql.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading