Ensure unqualified program names are present on PATH before executing them.
#309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgavin
force-pushed
the
safe-which
branch
5 times, most recently
from
b52982d to
bfa70b3
Compare
chrisgavin
force-pushed
the
safe-which
branch
from
bfa70b3 to
726cfc8
Compare
robertbrignull
approved these changes
Nov 19, 2020
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
The new dependency looks fine (the code looks good, and we got confirmation that using your library is fine). The rest of the code changes are pretty minimal. I've also reproduced the vulnerability and then that using your branch fixes it.
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids some potential issues when executing unqualified program names by using a custom library (which you can review here) to resolve them against the
PATHvariable first.Merge / deployment checklist