Skip to content

Make a few small tweaks to the update-supported-enterprise-server-versions script. #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisgavin merged 3 commits into from
Nov 4, 2020
Merged

Make a few small tweaks to the update-supported-enterprise-server-versions script. #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
beac9d5
Fix a copy and pasted job name.
chrisgavin Nov 3, 2020
4ffed26
Only increase the newest supported release, never reduce it.
chrisgavin Nov 3, 2020
813b523
Merge branch 'main' into tweak-bump-supported-versions
chrisgavin Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update-supported-enterprise-server-versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
- cron: "0 0 * * *"

jobs:
multi-language-repo_test-autodetect-languages:
update-supported-enterprise-server-versions:
runs-on: ubuntu-latest

steps:
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/update-supported-enterprise-server-versions/update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,18 @@
_FIRST_SUPPORTED_RELEASE = semver.VersionInfo.parse("2.22.0") # Versions older than this did not include Code Scanning.

def main():
api_compatibility_data = json.loads(_API_COMPATIBILITY_PATH.read_text())

releases = json.loads(_RELEASE_FILE_PATH.read_text())
oldest_supported_release = None
newest_supported_release = None
newest_supported_release = semver.VersionInfo.parse(api_compatibility_data["maximumVersion"] + ".0")

for release_version_string, release_data in releases.items():
release_version = semver.VersionInfo.parse(release_version_string + ".0")
if release_version < _FIRST_SUPPORTED_RELEASE:
continue

if newest_supported_release is None or release_version > newest_supported_release:
if release_version > newest_supported_release:
feature_freeze_date = datetime.date.fromisoformat(release_data["feature_freeze"])
if feature_freeze_date < datetime.date.today() + datetime.timedelta(weeks=2):
newest_supported_release = release_version
Expand Down