Skip to content

Add some more API-related configuration errors #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
henrymercer merged 2 commits into from
Apr 16, 2024
Merged

Add some more API-related configuration errors #2242

henrymercer merged 2 commits into from
Apr 16, 2024

Conversation

@henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Apr 15, 2024

Add API-related configuration errors for:

  • Commit doesn't exist
  • SARIF file doesn't exist
  • Same category used twice in same workflow

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner April 15, 2024 18:12
angelapwen
angelapwen approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@henrymercer henrymercer merged commit b8e2556 into main Apr 16, 2024
@henrymercer henrymercer deleted the henrymercer/even-more-configuration-errors branch April 16, 2024 09:58
This was referenced Apr 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@angelapwen angelapwen angelapwen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henrymercer @angelapwen