Skip to content

Conversation

@robertbrignull
Copy link
Contributor

@robertbrignull robertbrignull commented Sep 17, 2020

I realised that queries from the workflow were not being included in the status report from the init action.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

Copy link
Contributor

@sampart sampart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@robertbrignull
Copy link
Contributor Author

robertbrignull commented Sep 18, 2020

Thanks for the review. I'm going to add some quick tests of this if I can work out a good way to do it. Should be all test code though so less of a need to re-review unless you want to. Let me know.

@sampart
Copy link
Contributor

sampart commented Sep 18, 2020

I'd like to take a look, but you can merge prior to my re-review. Thanks

@robertbrignull
Copy link
Contributor Author

Unfortunately writing a unit test that creates a status report is quite a pain at the moment because it relies on lots of state. We should work towards making this easier, but right now I'm not sure it's worth it for this change.
I'm running some manual tests now and I'll check that the status reports show up correctly at the other end.

@robertbrignull robertbrignull merged commit b2dfa6e into main Sep 18, 2020
@robertbrignull robertbrignull deleted the robertbrignull/init_status_queries branch September 18, 2020 15:56
@github-actions github-actions bot mentioned this pull request Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants