Fix type error in Update release branch workflow
#2051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for i in range(int(major_version.strip("v"))-1, 0, -1): | ||
| branch_name = f"releases/v{i}" | ||
| if i >= OLDEST_SUPPORTED_MAJOR_VERSION: | ||
| if i >= int(OLDEST_SUPPORTED_MAJOR_VERSION): |
Contributor
There was a problem hiding this comment.
This is the only use of this variable so it works; the more durable option would be to typecast at the definition of OLDEST_SUPPORTED_MAJOR_VERSION.
Contributor
Author
There was a problem hiding this comment.
Ah, that's fair — I had thought it might be easier to explicitly cast when used but I guess we'd always be using it as an int. I'll update.
adityasharad
approved these changes
Dec 21, 2023
This was referenced Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply casts a string to an int 😸
Merge / deployment checklist