Send tool names to upload endpoint #2
Conversation
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
Implementation LGTM but I think this PR is missing the file with the new tests
Thanks for mentioning that, I've pushed it up now 👍 |
|
@robertbrignull should I target |
|
Target |
|
What tests have you run? Did you try with a third party tool or with an upload that contains multiple tools? I'll start a run on https://github.com/Anthophila/test-electron as that should try all those options. |
Apologies I misread this as CI passes, not manual tests. |
|
I thought the sast-scan action uploaded multiple files but unfortuantely it doesn't. I'm adding a new workflow to that repo that runs multiple tools. You can see it at https://github.com/Anthophila/test-electron/runs/630193543?check_suite_focus=true |
|
I had to reduce the number of tools because it wasn't finishing, but I got a run to succeed: https://github.com/Anthophila/test-electron/runs/630367911?check_suite_focus=true |
Thanks for confirming, merging 👍 |
# This is the 1st commit message: Add logic to download codeql platform-language pkg * Add `bundleName` argument to `getCodeQLBundleDownloadURL` * Add `languages` argument to `setupCodeQL`. The logic now tries to find the platform-language pkg before defaulting to the full bundle. We keep the toolcache clean by adding the pl version to the tool version. # The commit message #2 will be skipped: # Add simple fallback logic for download # The commit message #3 will be skipped: # wip linter # The commit message #4 will be skipped: # linter
# This is the 1st commit message: Add logic to download codeql platform-language pkg * Add `bundleName` argument to `getCodeQLBundleDownloadURL` * Add `languages` argument to `setupCodeQL`. The logic now tries to find the platform-language pkg before defaulting to the full bundle. We keep the toolcache clean by adding the pl version to the tool version. # The commit message #2 will be skipped: # add test # The commit message #3 will be skipped: # cleanup # The commit message #4 will be skipped: # linter
This pull request sends an array of all the tool names included in the sarif files to the upload endpoint.
Merge / deployment checklist