Skip to content

Don't log invalid cgroup memory limits #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
henrymercer merged 1 commit into from
Sep 27, 2023
Merged

Don't log invalid cgroup memory limits #1904

henrymercer merged 1 commit into from
Sep 27, 2023

Conversation

@henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Sep 27, 2023

On some versions of Linux, such as Ubuntu 20.04, the cgroups file contains MAX_INT when there is no cgroup memory limit. This PR avoids info logging those limits, to prevent confusion.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner September 27, 2023 13:02
@henrymercer henrymercer merged commit 9ef3267 into main Sep 27, 2023
@henrymercer henrymercer deleted the henrymercer/tweak-cgroup-ram-logging branch September 27, 2023 15:43
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityasharad adityasharad adityasharad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henrymercer @adityasharad