Clean up the bundle archive after extracting it #1820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasharad
previously approved these changes
Aug 1, 2023
adityasharad
reviewed
Aug 1, 2023
adityasharad
reviewed
Aug 1, 2023
adityasharad
approved these changes
Aug 1, 2023
Contributor
Author
|
I reran https://github.com/github/codeql-action/actions/runs/5730681885/job/15530162792?pr=1820 in debug. Logs are looking good. |
Contributor
|
Just curious: how exactly did you figure out the disk space savings here? |
Contributor
Author
|
I did a fairly basic calculation: I added a bunch of print statements to dump the available disk space, and summed the amount of disk space made available by deleting the archived bundle and deleting the extracted bundle from the temporary directory. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some more disk space available to future steps by deleting the CodeQL bundle archive once we've extracted it. We tolerate this step failing since deleting files doesn't always work, particularly on Windows where an antivirus program might lock the file.
Edit: There's another saving to be had — when we cache the bundle we copy it from a temporary directory to a toolcache directory, so we can also delete the extracted CodeQL bundle from this temporary directory.
In total, we make an additional 2.3 GB available to the
autobuildandanalyzesteps on a Linux run using a single-platform dist. The savings are better for multi-platform dists, but these are less common.Merge / deployment checklist