Fix "Using a custom configuration" link in the README #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the "Using a custom configuration" link the README. The actual ID of the header on the page is "using-a-custom-configuration-file", so I updated both the link and the link test to match. (as far as I can tell all other links in the README work as expected)
Contributor
|
Thanks for spotting that and fixing it 👍 Thanks for the point about "Specifying directories to scan" too. I've forwarded this onto the docs team and we'll try to get that page fixed as soon as possible. |
robertbrignull
approved these changes
Sep 11, 2020
Contributor
|
We can ignore that one job failure. There's no way this PR broke it. I think that job just doesn't work on PRs from forks, but we'll look into it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist
Description
Fix the "Using a custom configuration" link the README. The actual ID of the header on the page is
#using-a-custom-configuration-file, so I updated both the link and the link title to match. (as far as I can tell all other links in the README work as expected.)As an aside (not sure where best to report this), the snippet for Specifying directories to scan in the docs seems to be outdated.
paths-ignoreandpathscan no longer be specified in thewith:statement, according to this error message: