Split up builtin and custom queries #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
If we would like to use the |
Contributor
Author
|
In the |
Contributor
Author
|
Although I noticed we aren't populating the status report quite right. I've opened #219 to fix this. |
Contributor
|
Great, I'm happy then. |
rneatherway
approved these changes
Sep 17, 2020
Contributor
Author
|
Just for the record, I've confirmed that the status reports are getting through correctly and this timing data is arriving. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits up the storage and running of builtin and custom queries. This enables us to time each set separately and populate the fields in the status report.
In
runQueriesinanalyze.tsI had to get a little bit loose with the typing in order to populate the status report. The alternative would have been a massive switch to convert strings into the well-typed field names. It didn't seem worth it to me, but I'm open to being persuaded. I added a test for this method that hopefully will catch if we accidentally rename something that breaks assumptions.Merge / deployment checklist