Add another fingerprinting test #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgavin
approved these changes
Sep 10, 2020
Contributor
chrisgavin
left a comment
chrisgavin
left a comment
There was a problem hiding this comment.
I didn't realize this happened in such a simple file. Wow.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't add too much but this test file came up as a source of fingerprinting inconsistencies w.r.t. CodeQL. I think we should add it as a test case now so we are asserting our behaviour on it and then if it does turn out there's a bug in our algorithm it'll be obvious when we fix it.
Merge / deployment checklist