Skip to content

add error-catching wrapper around calls to toolrunner #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickfyson merged 22 commits into from
Sep 14, 2020
Merged

add error-catching wrapper around calls to toolrunner #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2b27c68
add exec_wrapper function
nickfyson Aug 21, 2020
45e00a8
match existing behaviour when custom listeners defined
nickfyson Aug 24, 2020
cd22abc
add example regex match for stdout/err string
nickfyson Aug 24, 2020
7b7e0e1
update error_wrapper to take matcher array
nickfyson Sep 1, 2020
6ef5334
wrap more codeql calls in the error catcher wrapper
nickfyson Sep 1, 2020
231537b
refactor to handle exec.exec return values together
nickfyson Sep 2, 2020
6a43a61
ensure matchers not applied if exit code is zero
nickfyson Sep 3, 2020
dd4e841
remove spurious use of exec_wrapper
nickfyson Sep 3, 2020
9701a93
ensure exec_wrapper always captures exit code of called process
nickfyson Sep 7, 2020
1f3ce75
add initial suite of tests for exec_wrapper
nickfyson Sep 7, 2020
7dbaff0
move error matcher definition into dedicated file
nickfyson Sep 7, 2020
3e6d239
add test for initial error matcher
nickfyson Sep 7, 2020
cc2dfaf
clean up and rename things to follow proper conventions
nickfyson Sep 7, 2020
30bb37a
restore all default workflow triggers and integration tests
nickfyson Sep 7, 2020
c4f579a
remove the intentionally failing matcher integration tests
nickfyson Sep 7, 2020
3cd4127
Merge branch 'main' into nickfyson/error_wrapper
nickfyson Sep 7, 2020
88951d6
renames to reflect the switch to using toolrunner
nickfyson Sep 7, 2020
1fb7c81
tweak in response to reviewer comments
nickfyson Sep 11, 2020
b3b9901
make ErrorMatcher an object rather than a tuple
nickfyson Sep 11, 2020
b104d6e
Merge branch 'main' into nickfyson/error_wrapper
nickfyson Sep 11, 2020
814840b
Merge branch 'main' into nickfyson/error_wrapper
nickfyson Sep 14, 2020
e5e9aad
Merge branch 'main' into nickfyson/error_wrapper
nickfyson Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/codeql.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codeql.js.map
View file
Open in desktop

Large diffs are not rendered by default.

17 changes: 17 additions & 0 deletions lib/error-matcher.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions lib/error-matcher.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 29 additions & 0 deletions lib/error-matcher.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions lib/error-matcher.test.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

86 changes: 86 additions & 0 deletions lib/toolrunner-error-catcher.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions lib/toolrunner-error-catcher.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

145 changes: 145 additions & 0 deletions lib/toolrunner-error-catcher.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading