Tolerate unexpected processing statuses for unsuccessful execution SARIF uploads #1732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
force-pushed
the
henrymercer/tolerate-unexpected-processing-statuses
branch
from
4419fb4 to
4d7934a
Compare
angelapwen
approved these changes
Jun 14, 2023
Contributor
angelapwen
left a comment
angelapwen
left a comment
There was a problem hiding this comment.
Thanks for the detailed description, just a suggestion for the debug log!
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
henrymercer
force-pushed
the
henrymercer/tolerate-unexpected-processing-statuses
branch
from
1a27e21 to
d6201b5
Compare
angelapwen
approved these changes
Jun 17, 2023
henrymercer
deleted the
henrymercer/tolerate-unexpected-processing-statuses
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a known transient issue with the code scanning API where it sometimes reports
completefor an unsuccessful execution submission. The API should always reportfailedwith a single "unsuccessful execution" processing error.Previously the CodeQL Action threw an error when it received an unexpected processing status. This PR relaxes this behaviour to:
complete, print a debug log instead, since this transient issue does not typically indicate that code scanning status information will be out of date.failedwith other processing errors, print a warning, such that Actions will focus on the earlier failure when a user views the workflow run. The failure that caused us to upload an unsuccessful execution SARIF file is probably more relevant than the failure to upload this SARIF file.Merge / deployment checklist