github · Daverlo · Sep 11, 2020 · Sep 7, 2020 · Sep 7, 2020
diff --git a/python-setup/auto_install_packages.py b/python-setup/auto_install_packages.py
@@ -50,7 +50,7 @@ def install_packages_with_pipenv():
     return python_executable_path
 
 
-def install_requirements_txt_packages(version: int, requirements_txt_path: str):
+def _create_venv(version: int):
     # create temporary directory ... that just lives "forever"
     venv_path = mkdtemp(prefix='codeql-action-python-autoinstall-')
 
@@ -62,14 +62,42 @@ def install_requirements_txt_packages(version: int, requirements_txt_path: str):
     elif version == 3:
         _check_call(['python3', '-m', 'virtualenv', venv_path])
 
+    return venv_path
+
+
+def install_requirements_txt_packages(version: int):
+    venv_path = _create_venv(version)
     venv_pip = os.path.join(venv_path, 'bin', 'pip')
+    venv_python = os.path.join(venv_path, 'bin', 'python')
+
     try:
-        _check_call([venv_pip, 'install', '-r', requirements_txt_path])
+        _check_call([venv_pip, 'install', '-r', 'requirements.txt'])
     except subprocess.CalledProcessError:
-        sys.exit('package installation with pip failed, see error above')
+        sys.exit('package installation with `pip install -r requirements.txt` failed, see error above')
+
+    return venv_python
+
 
+def install_with_setup_py(version: int):
+    venv_path = _create_venv(version)
+    venv_pip = os.path.join(venv_path, 'bin', 'pip')
     venv_python = os.path.join(venv_path, 'bin', 'python')
 
+    try:
+        # We have to choose between `python setup.py develop` and `pip install -e .`.
+        # Modern projects use `pip install -e .` and I wasn't able to see any downsides
+        # to doing so. However, `python setup.py develop` has some downsides -- from
+        # https://stackoverflow.com/a/19048754 :
+        # > Note that it is highly recommended to use pip install . (install) and pip
+        # > install -e . (developer install) to install packages, as invoking setup.py
+        # > directly will do the wrong things for many dependencies, such as pull
+        # > prereleases and incompatible package versions, or make the package hard to
+        # > uninstall with pip.
+
+        _check_call([venv_pip, 'install', '-e', '.'])
+    except subprocess.CalledProcessError:
+        sys.exit('package installation with `pip install -e .` failed, see error above')
+
     return venv_python
 
 
@@ -89,7 +117,11 @@ def install_packages() -> str:
 
     if os.path.exists('requirements.txt'):
         print('Found requirements.txt, will install packages with pip', flush=True)
-        return install_requirements_txt_packages(version, 'requirements.txt')
+        return install_requirements_txt_packages(version)
+
+    if os.path.exists('setup.py'):
+        print('Found setup.py, will install package with pip in editable mode', flush=True)
+        return install_with_setup_py(version)
 
     print("was not able to install packages automatically", flush=True)
 
@@ -107,9 +139,3 @@ def install_packages() -> str:
     if python_executable_path is not None:
         print("Setting CODEQL_PYTHON={}".format(python_executable_path))
         print("::set-env name=CODEQL_PYTHON::{}".format(python_executable_path))
-
-# TODO:
-# - no packages
-# - poetry without version
-# - pipenv without version
-# - pipenv without lockfile
diff --git a/python-setup/install_tools.sh b/python-setup/install_tools.sh
@@ -28,4 +28,6 @@ sudo apt-get install -y python3-venv
 #       "program uses threads.", RuntimeWarning)
 #     LGTM_PYTHON_SETUP_VERSION=The currently activated Python version 2.7.18 is not supported by the project (^3.5). Trying to find and use a compatible version. Using python3 (3.8.2) 3
 
-python3 -m pip install --user poetry pipenv
+# poetry 1.0.10 has error (https://github.com/python-poetry/poetry/issues/2711)
+python3 -m pip install --user poetry!=1.0.10
+python3 -m pip install --user pipenv