make inputting refs easier #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rneatherway, can you review this? Do you think applying this transformation makes sense so users can input the branch name they are familiar with? |
Contributor
I agree. It's still possible to specify that branch unambiguously using the full form so I think that's fine. |
rneatherway
approved these changes
Sep 7, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's annoying that you have to specify the ref to the API in it's full explicit format. Users definitely won't do this so I think we should prepend
refs/heads/if whatever they enter doesn't already start withresf/.I admit there is a slight possibilty for confusion if someone makes a branch legitimately called
refs/heads/refs/foobut this is quite unlikely.Merge / deployment checklist