Skip to content

Feature flag to disable python dependency installation #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RasmusWL merged 10 commits into from
May 16, 2023
Merged

Feature flag to disable python dependency installation #1676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0ccdbf8
Feature flag to disable python dependency installation
RasmusWL May 9, 2023
eb8a706
Update CHANGELOG.md
RasmusWL May 11, 2023
b8f39fe
Use features properly in `setupPythonExtractor`
RasmusWL May 12, 2023
cbc79bf
Merge branch 'main' into rasmuswl/python-disable-dependency-installation
RasmusWL May 12, 2023
c237da1
Fix linting errors
RasmusWL May 12, 2023
cc64156
Improve python warning message
RasmusWL May 12, 2023
fce87bb
Generate JS
RasmusWL May 12, 2023
cf58ef4
Update wording for CODEQL_PYTHON warning
RasmusWL May 15, 2023
e1cca25
Generate JS
RasmusWL May 15, 2023
dc0f6da
Update CHANGELOG.md
RasmusWL May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [UNRELEASED]

- We are rolling out a feature in May 2023 that will disable Python dependency installation for new users of the CodeQL Action. This improves the speed of analysis while having only a very minor impact on results. [#1676](https://github.com/github/codeql-action/pull/1676)
Copy link
Contributor

@aeisenberg aeisenberg May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning on doing a changelog post or some other public announcement? Especially explaining "a very minor impact on results" would be nice. If there is one, can you add a link here? If the post is planned, but the URL isn't known yet, we can always update this entry.

Copy link
Member Author

@RasmusWL RasmusWL May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, once we start roll it out to new users, there will be a public changelog post 👍

- Remove the requirement for `on.push` and `on.pull_request` to trigger on the same branches. [#1675](https://github.com/github/codeql-action/pull/1675)

## 2.3.3 - 04 May 2023
Expand Down
2 changes: 1 addition & 1 deletion lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze-action.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading