Skip to content

Run npm test on linux and macos #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbrignull merged 2 commits into from
Aug 28, 2020
Merged

Run npm test on linux and macos #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da1c00f
Run `npm test` on all operating systems
robertbrignull Aug 28, 2020
b1d719e
fix tests on non-linux
robertbrignull Aug 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,12 @@ jobs:
echo "Success: node_modules are up to date"

npm-test:
runs-on: ubuntu-latest
strategy:
matrix:
os: [ubuntu-latest,macos-latest]
Copy link
Contributor

@aeisenberg aeisenberg Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why windows isn't included here?

Copy link
Contributor Author

@robertbrignull robertbrignull Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests don't currently pass on windows and I think it's going to be a bit of effort to get them working. I want to do that but we may as well merge this now and do windows separately later.

Copy link
Contributor

@aeisenberg aeisenberg Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v1
- name: npm run-script test
run: npm run-script test
run: npm run-script test
16 changes: 11 additions & 5 deletions lib/tracer-config.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/tracer-config.test.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading