Run npm test on linux and macos
#164
Conversation
|
Oh, didn't realise the bug was already on this branch. Should be fixed now. I'm not sure if this is exactly the right fix as it does feel like we're just duplicating the implementation a bit. Alternative would be just deleting this test, but I think let's keep it for now. |
robertbrignull
force-pushed
the
npm_test_os
branch
from
09f107f to
c389791
Compare
robertbrignull
force-pushed
the
npm_test_os
branch
from
c389791 to
610632e
Compare
|
Ok. For now I've scaled this back to only running on linux and osx. We should get the tests running on windows too but it seems there are a bunch of failures and it'll be more effort. |
robertbrignull
force-pushed
the
npm_test_os
branch
from
610632e to
b1d719e
Compare
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest,macos-latest] |
There was a problem hiding this comment.
Any reason why windows isn't included here?
There was a problem hiding this comment.
The tests don't currently pass on windows and I think it's going to be a bit of effort to get them working. I want to do that but we may as well merge this now and do windows separately later.
robertbrignull
changed the title
npm test on all operating systemsnpm test on linux and macos
A change I made in #162 accidentally broke the unit tests on non-linux systems.
I think running just this on all development operating systems will be fine. We don't need to do the other jobs from this workflow.
Merge / deployment checklist