Skip to content

Upload per-database diagnostic SARIFs on green and red runs #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelapwen merged 28 commits into from
Mar 20, 2023
Merged

Upload per-database diagnostic SARIFs on green and red runs #1556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
5d87d01
Refactor golang autobuild env variable
angelapwen Mar 3, 2023
6b27d47
Add database diagnostic command, cluster env var
angelapwen Mar 3, 2023
0277876
Upload per-database failed SARIFs, if applicable
angelapwen Mar 3, 2023
b780f5b
Add autogenerated files
angelapwen Mar 3, 2023
1d4190a
Add `database export-diagnostics` command
angelapwen Mar 3, 2023
e6c90ea
Call `export diagnostics` if there is no database
angelapwen Mar 8, 2023
1f1b68b
Add new export_diagnostics feature flag
angelapwen Mar 8, 2023
3200bf1
Pass "--sarif-include-diagnostics" when feature flag on
angelapwen Mar 13, 2023
1e4efb1
Resolve merge conflicts
angelapwen Mar 13, 2023
ec89543
Remove --sarif-include-diagnostics from diagnotics export
angelapwen Mar 13, 2023
6cce51b
Fix export-diagnostics call
angelapwen Mar 13, 2023
ed73efb
Improve unit tests
angelapwen Mar 14, 2023
c193f61
Merge remote-tracking branch 'upstream/main' into failed-database-dia…
angelapwen Mar 15, 2023
30ddec6
Gate `database export-diagnostics` behind feature flag
angelapwen Mar 15, 2023
0c2bb50
[WIP] Add diagnostics export test
angelapwen Mar 15, 2023
0d25a3c
Try `database add-diagnostic`
angelapwen Mar 17, 2023
1fdf5c4
Move add diagnostic to before analyze
angelapwen Mar 17, 2023
7bda3d2
Add diagnostics option for green runs
angelapwen Mar 17, 2023
18c0c1a
Check SARIF in test for expected properties
angelapwen Mar 17, 2023
817a0e5
Rename test for consistency, stop db upload
angelapwen Mar 17, 2023
cb3dd65
Comment/import cleanup
angelapwen Mar 18, 2023
6ea3eb9
Test `nightly-latest` for diagnostics, config export
angelapwen Mar 20, 2023
9e6750d
Stop relying on SARIF ordering
angelapwen Mar 20, 2023
1954584
Print database diagnostics args if unit test fails
angelapwen Mar 20, 2023
9116cc1
Apply suggestions from code review
angelapwen Mar 20, 2023
0271b54
Add JSDoc comment
angelapwen Mar 20, 2023
3465159
Improve failure message, some autogenerated fixes
angelapwen Mar 20, 2023
e7e7280
Refactor inclusion check
angelapwen Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/__config-export.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

99 changes: 99 additions & 0 deletions .github/workflows/__diagnostics-export.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze-action.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading