You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has two goals, that both involve adding data to the internal config:
Add tempDir and toolCacheDir to the config. This doesn't make much difference now but it will make it easier in future for these values to come from the CLI instead of the environment.
Add codeQLCmd to the config. Currently we store the path to the CodeQL executable in the environment, but that won't be possible outside of actions. Instead we can store it in the config.
Merge / deployment checklist
Confirm this change is backwards compatible with existing workflows.
The changes are mostly fairly mechanical, adding these extra parameters throughout, and look correct.
It seems a bit strange to me that there are still many calls of util.getRequiredEnvParam('RUNNER_TEMP'). I would have expected that this wouldn't be necessary, perhaps by passing the config object around after it is first created. However, I am not well versed in how the action works so that may not be possible because, for example, the autobuild action is not called by us directly. It does seem surprising that finalize-db cannot have the config passed to it though.
At the end of the day it seems that we will need a single environment variable RUNNER_TEMP that tells us where to find the cached config after init has dealt with it the first time. Does that sound right?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has two goals, that both involve adding data to the internal config:
tempDirandtoolCacheDirto the config. This doesn't make much difference now but it will make it easier in future for these values to come from the CLI instead of the environment.codeQLCmdto the config. Currently we store the path to the CodeQL executable in the environment, but that won't be possible outside of actions. Instead we can store it in the config.Merge / deployment checklist