You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to remove a few elements from shared-environment.ts. Most of this is pretty easy because the variable is only used from one place, or the data is readily available in the config already.
This doesn't remove ODASA_TRACER_CONFIGURATION or CODEQL_WORKFLOW_STARTED_AT because those are unfortunately going to be slightly more tricky.
I think the only bit that needs explaining is the removal of should_abort. I claim this is safe to do because it's functionality of checking that the init action has already run is covered by the call to getConfig in the autobuild and analyze actions. In the init and upload-sarif actions, all it was doing was validating that the github ref env var was populated, which doesn't seem worth it to keep the function around.
Merge / deployment checklist
Confirm this change is backwards compatible with existing workflows.
#137 also introduced a list of the known languages to the config-utils file, and this PR introduces that list to the codeql file. I'd like to keep the data in one place, and based on the dependency direction I think that place has to be the codeql file, so I'll move the existing code to there.
#137 also introduced a list of the known languages to the config-utils file, and this PR introduces that list to the codeql file. I'd like to keep the data in one place, and based on the dependency direction I think that place has to be the codeql file, so I'll move the existing code to there.
After looking at this, it's going to involve a fair bit or refactoring and ideally I'd like to even introduce a new languages.ts file. So I propose leaving this PR as it is and doing that change separately.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to remove a few elements from
shared-environment.ts. Most of this is pretty easy because the variable is only used from one place, or the data is readily available in the config already.This doesn't remove
ODASA_TRACER_CONFIGURATIONorCODEQL_WORKFLOW_STARTED_ATbecause those are unfortunately going to be slightly more tricky.I think the only bit that needs explaining is the removal of
should_abort. I claim this is safe to do because it's functionality of checking that theinitaction has already run is covered by the call togetConfigin theautobuildandanalyzeactions. In theinitandupload-sarifactions, all it was doing was validating that the github ref env var was populated, which doesn't seem worth it to keep the function around.Merge / deployment checklist