Improve feedback about what files are being uploaded in the upload-sarif Action. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgavin
changed the title
chrisgavin
force-pushed
the
better-feedback-folder-uploads
branch
from
2cb9dd9 to
b6a0306
Compare
robertbrignull
approved these changes
May 1, 2020
| .filter(f => f.endsWith(".sarif")) | ||
| .map(f => path.resolve(input, f)); | ||
| if (sarifFiles.length === 0) { | ||
| core.setFailed("No SARIF files found to upload in \"" + input + "\"."); |
Contributor
There was a problem hiding this comment.
core.setFailed doesn't abort, so we'd still try to upload the emptyset of files.
I think it would be better to return here, but it's perhaps not essential.
Contributor
There was a problem hiding this comment.
But to clarify, this PR is a strict improvement as it is, so I have no opposition to merging as it is.
anaarmas
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes two changes designed to assist debugging the upload action. Firstly it increases the log level of the message listing which SARIF files are being uploaded, which is a very useful piece of information.
Secondly it fails the action if an attempt is made to upload a folder with no SARIF files in, since this is very likely to be a mistake.
Merge / deployment checklist