Avoid sending status reports on enterprise #128
Merged
+60
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
approved these changes
Jul 30, 2020
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
This looks right to me. A small note that when #117 is merged, the check for isEnterprise should happen after the check to isLocalRun.
Contributor
Author
|
I've tested this now and confirmed the reports are not sent and it doesn't fail. |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids us sending status reports when running on enterprise. The endpoint currently doesn't do anything that would be useful on enterprise.
This will probably conflict a little bit with #117 but I'll fix that up when it happens.
The check and the point where we revert is currently just before we actually send the status report, but notably this is after we've constructed the report, so there is a little bit of wasted effort. I think this is acceptable for the first attempt, though there's clearly room for improvement to avoid constructing the report while also keeping the centralised check and avoiding having to add checks to every call.
Things that need to be checked and tested before merging:
Merge / deployment checklist