Skip to content

Conversation

@RasmusWL
Copy link
Member

@RasmusWL RasmusWL commented Sep 19, 2022

Fixes #1241

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@RasmusWL RasmusWL marked this pull request as ready for review September 19, 2022 11:16
@RasmusWL RasmusWL requested review from a team as code owners September 19, 2022 11:16
tausbn
tausbn previously approved these changes Sep 19, 2022
Copy link

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. 👍

henrymercer
henrymercer previously approved these changes Sep 20, 2022
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small tweak to the changelog note and an optional comment.

Co-authored-by: Henry Mercer <henrymercer@github.com>
@RasmusWL RasmusWL dismissed stale reviews from henrymercer and tausbn via 1309aaf September 20, 2022 13:43
henrymercer
henrymercer previously approved these changes Sep 20, 2022
@RasmusWL RasmusWL merged commit 417059f into main Sep 21, 2022
@RasmusWL RasmusWL deleted the rasmuswl/poetry-v1.2 branch September 21, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poetry 1.2 support

4 participants