Use templated strings for better readability #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
force-pushed
the
aeisenberg/ignore
branch
2 times, most recently
from
012f4da to
ac884fe
Compare
robertbrignull
approved these changes
Jul 24, 2020
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
Couple of changes to the wording of messages which I don't feel are improvements. But overall thanks this looks good.
I'l leave it to you to make the suggested changes or not, and merge when you're happy.
src/fingerprints.ts
Outdated
| location.index >= artifacts.length || | ||
| typeof artifacts[location.index].location !== 'object') { | ||
| core.debug('Ignoring location as index "' + location.index + '" is invalid'); | ||
| core.debug(`Ignoring location URI "${location.index}" is invalid`); |
Contributor
There was a problem hiding this comment.
The text changed here too which looks like a mistake
src/fingerprints.ts
Outdated
| // Get the URI and decode | ||
| if (typeof location.uri !== 'string') { | ||
| core.debug('Ignoring location as uri "' + location.uri + '" is invalid'); | ||
| core.debug(`Ignoring location URI "${location.uri}" is invalid`); |
Contributor
There was a problem hiding this comment.
The removal of the word "as" makes this harder to read, though I admit it is an error message so perfect grammar is not of the greatest importance. Still I think the removal as "as" is negative change.
aeisenberg
force-pushed
the
aeisenberg/ignore
branch
2 times, most recently
from
23ad9cf to
cbe0b21
Compare
aeisenberg
force-pushed
the
aeisenberg/ignore
branch
from
cbe0b21 to
b2e688c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist