Report status as failure if upload fails in the finalize or upload action #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbrignull
approved these changes
May 1, 2020
Contributor
|
Has conflicts now |
anaarmas
reviewed
May 1, 2020
|
|
||
| run().catch(e => { | ||
| core.setFailed("upload-sarif action failed: " + e); | ||
| core.setFailed("codeql/upload-sarif action failed: " + e); |
Contributor
There was a problem hiding this comment.
I don't think this line should've been changed
Contributor
There was a problem hiding this comment.
Indeed this is a regression. Presumably a merge conflict confusion. It's not the end of the world though and won't affect anything negatively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist
https://github.com/Anthophila/test-electron/actions/runs/93132106✔️https://github.com/Anthophila/test-electron/actions/runs/93132108✔️