Skip to content

Fix cache key for TRAP caching #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edoardopirovano merged 1 commit into from
Aug 16, 2022
Merged

Fix cache key for TRAP caching #1183

edoardopirovano merged 1 commit into from
Aug 16, 2022

Conversation

@edoardopirovano
Copy link
Contributor

@edoardopirovano edoardopirovano commented Aug 16, 2022

Observed when testing this out internally. cachePrefix already returns a key that ends with a - so we don't need to add another one in.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@edoardopirovano edoardopirovano requested a review from a team as a code owner August 16, 2022 09:21
@edoardopirovano edoardopirovano merged commit ca10a6d into main Aug 16, 2022
@edoardopirovano edoardopirovano deleted the edoardo/fix-cache-key branch August 16, 2022 09:52
This was referenced Aug 17, 2022
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edoardopirovano @henrymercer