Add telemetry for TRAP caching #1182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardopirovano
force-pushed
the
edoardo/trap-cache-telemetry
branch
from
3b448b5 to
6162433
Compare
Contributor
Author
|
Changing to draft as we need a difference dependency with a more open license. |
edoardopirovano
force-pushed
the
edoardo/trap-cache-telemetry
branch
from
6162433 to
20daf81
Compare
edoardopirovano
added
the
Update dependencies
github-actions
bot
removed
the
Update dependencies
edoardopirovano
force-pushed
the
edoardo/trap-cache-telemetry
branch
from
9f4066c to
7a0f475
Compare
edoardopirovano
added
the
Update dependencies
github-actions
bot
removed
the
Update dependencies
edoardopirovano
force-pushed
the
edoardo/trap-cache-telemetry
branch
from
7d3ceb9 to
4139682
Compare
Contributor
Author
|
This is now ready for review again. |
henrymercer
reviewed
Aug 16, 2022
henrymercer
approved these changes
Aug 16, 2022
Contributor
henrymercer
left a comment
henrymercer
left a comment
There was a problem hiding this comment.
Minor comment around the get-folder-size package, otherwise LGTM.
3 tasks
This was referenced Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some telemetry for TRAP caching including the times and sizes of the cache uploads/downloads and the languages that we are using TRAP caching for. Almost all of the code change is adding a dependency that computes the recursive size of folders. This is a little jarring, but is I think simpler than writing that code ourselves which is potentially somewhat awkward. I'm definitely open to other suggestions on if there's a simpler way to get the size of the cache, though.
Merge / deployment checklist