Add option to override TRAP caching feature flag #1170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esbena
reviewed
Aug 5, 2022
Contributor
esbena
left a comment
esbena
left a comment
There was a problem hiding this comment.
Perhaps add a comment about this being a noop, otherwise curious users will stumble upon it and complain that it does not work.
edoardopirovano
force-pushed
the
edoardo/add-trap-cache-option
branch
from
38c9144 to
2d5738c
Compare
esbena
approved these changes
Aug 5, 2022
This was referenced Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a no-op for now, but let's add it in so DCA can opt out already without any warnings.
Merge / deployment checklist