Add dependency on @actions/cache
#1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardopirovano
added
the
Update dependencies
github-actions
bot
removed
the
Update dependencies
edoardopirovano
force-pushed
the
edoardo/add-cache-dep
branch
from
8d9f6af to
6b2d7eb
Compare
edoardopirovano
force-pushed
the
edoardo/add-cache-dep
branch
from
6b2d7eb to
38c2c09
Compare
criemen
approved these changes
Aug 5, 2022
Contributor
criemen
left a comment
criemen
left a comment
There was a problem hiding this comment.
LGTM, but I'm not really sure how to review this PR, outside from the changes to package.json.
Contributor
Author
I don't think there's much more to review than that. This CI check will make sure everything else matches what's declared there. |
This was referenced Aug 17, 2022
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency isn't actually used yet, but will be needed for the TRAP caching feature that I am currently working on. I was originally planning to add it in the same PR where it gets used, but given how many changes to transitive dependencies this generates, I think it makes sense to do it before in a separate PR to make reviewing easier and also test this in isolation.
Merge / deployment checklist