Skip to content

CI: Combine JS lint and JS check jobs #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityasharad merged 1 commit into from
Jul 28, 2022
Merged

CI: Combine JS lint and JS check jobs #1157

adityasharad merged 1 commit into from
Jul 28, 2022

Conversation

@adityasharad
Copy link
Contributor

@adityasharad adityasharad commented Jul 28, 2022 •
edited
Loading

Reduce the number of concurrent jobs (by 1, but every job counts!).
This will require a branch protection rule update, renaming check-js to Check JS and removing Lint.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • [N/A] Confirm the readme has been updated if necessary.
  • [N/A] Confirm the changelog has been updated if necessary.

@adityasharad
CI: Combine JS lint and JS check jobs
992d011 
Reduce the number of concurrent jobs.
This will require a branch protection rule update,
renaming `check-js` to Check JS` and removing `Lint`.
@adityasharad adityasharad requested a review from a team as a code owner July 28, 2022 22:39
aeisenberg
aeisenberg approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small win. Looks reasonable.

@aeisenberg
Copy link
Contributor

aeisenberg commented Jul 28, 2022 •
edited
Loading

This will need updating of the required checks.

@adityasharad
Copy link
Contributor Author

adityasharad commented Jul 28, 2022 •
edited
Loading

Manually updated branch protection on main, releases/v2, and releases/v1 to account for this PR and #1152.

@adityasharad adityasharad enabled auto-merge July 28, 2022 22:54
@adityasharad adityasharad merged commit b100b75 into main Jul 28, 2022
@adityasharad adityasharad deleted the adityasharad/actions/combine-lint-check-js branch July 28, 2022 23:30
This was referenced Aug 3, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adityasharad @aeisenberg