Add capability to filter queries #1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a `query-filters` property to the codeql-config file. This property is an array of `exclude`/`include` entries for a query suite. These filters are appended to the generated query suite files and used to filter queries after they are selected. A related change is that now, all pack references are run in a single query suite, which has the query filters appended to them.
aeisenberg
force-pushed
the
aeisenberg/remove-queries
branch
5 times, most recently
from
153ab19 to
b0c630e
Compare
aeisenberg
force-pushed
the
aeisenberg/remove-queries
branch
from
b0c630e to
eec34d5
Compare
henrymercer
reviewed
Jun 15, 2022
Removes duplicated yaml. Also add some better typings.
aeisenberg
force-pushed
the
aeisenberg/remove-queries
branch
from
6772540 to
59ca9b5
Compare
henrymercer
approved these changes
Jun 16, 2022
Contributor
henrymercer
left a comment
henrymercer
left a comment
There was a problem hiding this comment.
A few minor comments, but generally this looks good to me.
| @@ -0,0 +1,10 @@ | |||
| name: "CodeQL config 1" | |||
Contributor
There was a problem hiding this comment.
Thanks for naming the tests in the workflow file. We could potentially add those names here too.
| - include: | ||
| tags contain: external/cwe/cwe-022 | ||
|
|
||
| # Removes out js/path-injection |
Contributor
There was a problem hiding this comment.
Suggested change
| # Removes out js/path-injection | |
| # Removes js/path-injection |
| - include: | ||
| tags contain: external/cwe/cwe-022 | ||
|
|
||
| # Removes out js/path-injection |
Contributor
There was a problem hiding this comment.
Suggested change
| # Removes out js/path-injection | |
| # Removes js/path-injection |
| - include: | ||
| tags contain: external/cwe/cwe-022 | ||
|
|
||
| # Removes out js/path-injection |
Contributor
There was a problem hiding this comment.
Suggested change
| # Removes out js/path-injection | |
| # Removes js/path-injection |
aeisenberg
added a commit
that referenced
this pull request
Jun 16, 2022
Add capability to filter queries
This was referenced Jun 21, 2022
Contributor
Author
|
I am reverting this feature and creating a new release without it since we don't want this feature in GHES 3.6. |
aeisenberg
added a commit
that referenced
this pull request
Jun 21, 2022
3 tasks
aeisenberg
added a commit
that referenced
this pull request
Jun 21, 2022
aeisenberg
added a commit
that referenced
this pull request
Jun 21, 2022
aeisenberg
added a commit
that referenced
this pull request
Jun 21, 2022
Revert "Add capability to filter queries #1098"
This was referenced Jun 22, 2022
aeisenberg
added a commit
that referenced
this pull request
Jun 27, 2022
This reverts commit 99d4397.
3 tasks
This was referenced Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
query-filtersproperty to the codeql-config file.This property is an array of
exclude/includeentries for a querysuite. These filters are appended to the generated query suite files
and used to filter queries after they are selected.
A related change is that now, all pack references are run in a single
query suite, which has the query filters appended to them.
Merge / deployment checklist