Exclude lib directory from analysis #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbrignull
changed the title
Contributor
Author
|
Good, this reports 1 fix as I would expect |
Merged
This was referenced Apr 24, 2023
This was referenced Apr 24, 2023
This was referenced Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we want to be analyzing the
libdirectory as that's all generated code and we're currently getting some duplicate alerts showing up.It'll theoretically also show up alerts from dependencies, although I can't actually see any such alerts right now. Although this could be informative, it's not the way that codeql is meant to be used. It'll be more useful to rely on things like CVEs and dependabot to find out about vulnerabilities in dependencies.
Merge / deployment checklist