Improve errors & warnings in autobuild #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbrignull
approved these changes
Apr 30, 2020
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
I've explained my comment from earlier. Other than that LGTM
src/autobuild.ts
Outdated
|
|
||
| run().catch(e => { | ||
| core.setFailed("autobuild action failed: " + e); | ||
| core.setFailed("We were unable to automatically build your code. Please replace the call to the autobuild action with your custom build steps. codeql/autobuild action failed. " + e); |
Contributor
There was a problem hiding this comment.
Sorry the comment has got lost now. What I was saying earlier was that this catch block won't catch what you want. You want to leave this catch as it is and add this error message to the catch on line 52. This catch block will only get errors from our code like reportActionSucceeded.
anaarmas
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds better messaging to tell the user what languages we aren't autobuilding and prompts them to replace this action with custom build steps if we do fail.
Merge / deployment checklist