Move failed status report code into sendFailedStatusReport

mbg · mbg · commit 4dcc8a9cdcf5 · 2026-01-29T10:28:55.000Z
diff --git a/lib/start-proxy-action.js b/lib/start-proxy-action.js
diff --git a/src/start-proxy-action.ts b/src/start-proxy-action.ts
@@ -15,16 +15,11 @@ import {
   getCredentials,
   getDownloadUrl,
   parseLanguage,
+  sendFailedStatusReport,
   sendSuccessStatusReport,
   UPDATEJOB_PROXY,
 } from "./start-proxy";
-import {
-  ActionName,
-  createStatusReportBase,
-  getActionsStatus,
-  sendStatusReport,
-  sendUnhandledErrorStatusReport,
-} from "./status-report";
+import { ActionName, sendUnhandledErrorStatusReport } from "./status-report";
 import * as util from "./util";
 
 const KEY_SIZE = 2048;
@@ -152,25 +147,7 @@ async function run(startedAt: Date) {
       logger,
     );
   } catch (unwrappedError) {
-    const error = util.wrapError(unwrappedError);
-    core.setFailed(`start-proxy action failed: ${error.message}`);
-
-    // We skip sending the error message and stack trace here to avoid the possibility
-    // of leaking any sensitive information into the telemetry.
-    const errorStatusReportBase = await createStatusReportBase(
-      ActionName.StartProxy,
-      getActionsStatus(error),
-      startedAt,
-      {
-        languages: language && [language],
-      },
-      await util.checkDiskUsage(logger),
-      logger,
-      "Error from start-proxy Action omitted",
-    );
-    if (errorStatusReportBase !== undefined) {
-      await sendStatusReport(errorStatusReportBase);
-    }
+    await sendFailedStatusReport(logger, startedAt, language, unwrappedError);
   }
 }
 
diff --git a/src/start-proxy.ts b/src/start-proxy.ts
@@ -9,6 +9,7 @@ import { Logger } from "./logging";
 import {
   ActionName,
   createStatusReportBase,
+  getActionsStatus,
   sendStatusReport,
   StatusReportBase,
 } from "./status-report";
@@ -52,6 +53,41 @@ export async function sendSuccessStatusReport(
   }
 }
 
+/**
+ * Sends a status report for the `start-proxy` action indicating a failure.
+ *
+ * @param logger The logger to use.
+ * @param startedAt When the action was started.
+ * @param language The language provided as input, if any.
+ * @param unwrappedError The exception that was thrown.
+ */
+export async function sendFailedStatusReport(
+  logger: Logger,
+  startedAt: Date,
+  language: KnownLanguage | undefined,
+  unwrappedError: unknown,
+) {
+  const error = util.wrapError(unwrappedError);
+  core.setFailed(`start-proxy action failed: ${error.message}`);
+
+  // We skip sending the error message and stack trace here to avoid the possibility
+  // of leaking any sensitive information into the telemetry.
+  const errorStatusReportBase = await createStatusReportBase(
+    ActionName.StartProxy,
+    getActionsStatus(error),
+    startedAt,
+    {
+      languages: language && [language],
+    },
+    await util.checkDiskUsage(logger),
+    logger,
+    "Error from start-proxy Action omitted",
+  );
+  if (errorStatusReportBase !== undefined) {
+    await sendStatusReport(errorStatusReportBase);
+  }
+}
+
 export const UPDATEJOB_PROXY = "update-job-proxy";
 export const UPDATEJOB_PROXY_VERSION = "v2.0.20250624110901";
 const UPDATEJOB_PROXY_URL_PREFIX =
