Python: Promote py/pam-auth-bypass#9108
Merged
tausbn merged 9 commits intogithub:mainfrom May 23, 2022
Merged
Conversation
99% of our .qhelp files have manually wrapped lines, so just wanted to keep things consistent
They did not have proper formatting (only 2 spaces), and I restructured them a bit more so they look like code in the wild
Thought that calling out the actual vulnerability would make things easier for our end users :)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The value 8.1 was calculated by our internal tool. This corresponds to a 'High' severity, which from my gut feeling seems reasonable for authorization bypass.
tausbn
requested changes
May 17, 2022
Contributor
tausbn
left a comment
tausbn
left a comment
There was a problem hiding this comment.
A few minor bits and bobs that need fixing (most of them presented as suggestions for easy inclusion), but otherwise this looks good to me. 👍
| @@ -0,0 +1,19 @@ | |||
| libpam = CDLL(find_library("pam")) | |||
Contributor
There was a problem hiding this comment.
That's... Quite the formatting. 😮
python/ql/test/query-tests/Security/CWE-285-PamAuthorization/PamAuthorization.expected
Outdated
Show resolved
Hide resolved
| @@ -33,4 +34,5 @@ where | |||
| acctMgmtCall = libPam().getMember("pam_acct_mgmt").getACall() and | |||
Contributor
There was a problem hiding this comment.
I'm not allowed to add a comment in the appropriate place, but there's a use of API::moduleImport("ctypes.util") on line 20 above that will need fixing.
Member
Author
There was a problem hiding this comment.
indeed, that probably what the merge conflict is also about 👍
Co-authored-by: Taus <tausbn@github.com>
tausbn
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This promotes the experimental query from #8595