Skip to content

JavaScript: Introduce localTaintStep predicate. #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
semmle-qlci merged 1 commit into from
Dec 2, 2019
+10 −0
Merged

JavaScript: Introduce localTaintStep predicate. #2479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1573,4 +1573,6 @@ module DataFlow {
import Configuration
import TrackedNodes
import TypeTracking

predicate localTaintStep = TaintTracking::localTaintStep/2;
}
8 changes: 8 additions & 0 deletions javascript/ql/src/semmle/javascript/dataflow/TaintTracking.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,4 +885,12 @@ module TaintTracking {

override predicate appliesTo(Configuration cfg) { any() }
}

/**
* Holds if taint propagates from `pred` to `succ` in one local (intra-procedural) step.
*/
predicate localTaintStep(DataFlow::Node pred, DataFlow::Node succ) {
DataFlow::localFlowStep(pred, succ) or
any(AdditionalTaintStep s).step(pred, succ)
}
}