Skip to content

Unified: convert data extensions to JSON #23101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickrolfe merged 2 commits into from
Nov 11, 2026
+1,260 −1,220
Merged

Unified: convert data extensions to JSON #23101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
454adf5
Unified: convert data extensions to JSON
nickrolfe Nov 11, 2026
1a8badc
Unified: convert test data extensions to JSON
nickrolfe Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,207 changes: 1,207 additions & 0 deletions unified/ql/lib/ext/legacy-swift.model.json
View file
Open in desktop

Large diffs are not rendered by default.

1,189 changes: 0 additions & 1,189 deletions unified/ql/lib/ext/legacy-swift.model.yml
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions unified/ql/lib/qlpack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@ dependencies:
codeql/util: ${workspace}
dataExtensions:
- ext/*.model.yml
- ext/*.model.json
warnOnImplicitThis: true
compileForOverlayEval: true
28 changes: 28 additions & 0 deletions unified/ql/test/library-tests/dataflow/test.ext.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"extensions": [
{
"addsTo": {
"pack": "codeql/unified-all",
"extensible": "legacySummaryModel"
},
"data": [
// namespace, type, subtypes, name, signature, ext, input, output, kind, provenance
["", "TestType", true, "identityFlow(_:)", "", "", "Argument[0]", "ReturnValue", "value", "manual"],
["", "TestType", true, "storeArray(_:)", "", "", "Argument[0]", "ReturnValue.ArrayElement", "value", "manual"],
["", "TestType", true, "readArray(_:)", "", "", "Argument[0].ArrayElement", "ReturnValue", "value", "manual"],
["", "TestType", true, "postUpdateArg(_:output:)", "", "", "Argument[0]", "Argument[output:].Member[outputField]", "value", "manual"],
["", "TestType", true, "storeUnusualName(_:)", "", "", "Argument[0]", "ReturnValue.Member[unusualNameNotAppearingInSourceCode]", "value", "manual"],
["", "TestType", true, "readUnusualName(_:)", "", "", "Argument[0].Member[unusualNameNotAppearingInSourceCode]", "ReturnValue", "value", "manual"],
["", "TestType", true, "intoCallback(_:_:)", "", "", "Argument[0]", "Argument[1].Parameter[0]", "value", "manual"],
["", "TestType", true, "outOfCallback(_:)", "", "", "Argument[0].ReturnValue", "ReturnValue", "value", "manual"],
["", "TestType", true, "throughCallback(_:_:)", "", "", "Argument[0]", "Argument[1].Parameter[0]", "value", "manual"],
["", "TestType", true, "throughCallback(_:_:)", "", "", "Argument[1].ReturnValue", "ReturnValue", "value", "manual"],
["", "TestType", true, "taintFlow(_:)", "", "", "Argument[0]", "ReturnValue", "taint", "manual"],
["", "TestType", true, "swap(_:_:)", "", "", "Argument[0]", "Argument[1]", "value", "manual"],
["", "TestType", true, "swap(_:_:)", "", "", "Argument[1]", "Argument[0]", "value", "manual"],
["", "TestType", true, "getField()", "", "", "Argument[self].Member[field]", "ReturnValue", "value", "manual"],
["", "TestType", true, "setField(_:)", "", "", "Argument[0]", "Argument[self].Member[field]", "value", "manual"]
]
}
]
}
20 changes: 0 additions & 20 deletions unified/ql/test/library-tests/dataflow/test.ext.yml
View file
Open in desktop

This file was deleted.

24 changes: 24 additions & 0 deletions unified/ql/test/library-tests/mad/test.ext.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"extensions": [
{
"addsTo": {
"pack": "codeql/unified-all",
"extensible": "legacySourceModel"
},
"data": [
// namespace, type, subtypes, name, signature, ext, output, kind, provenance
["", "ShorthandTest", true, "sourceParams(_:)", "", "", "Parameter[self,0]", "shorthand-source", "manual"]
]
},
{
"addsTo": {
"pack": "codeql/unified-all",
"extensible": "legacySinkModel"
},
"data": [
// namespace, type, subtypes, name, signature, ext, input, kind, provenance
["", "ShorthandTest", true, "sinkArgs(_:)", "", "", "Argument[self,0]", "shorthand-sink", "manual"]
]
}
]
}
11 changes: 0 additions & 11 deletions unified/ql/test/library-tests/mad/test.ext.yml
View file
Open in desktop

This file was deleted.

Loading