Repository navigation
Unified: convert data extensions to JSON - #23101
Merged
Merged
Conversation
nickrolfe
changed the title
nickrolfe
marked this pull request as ready for review
November 11, 2026 14:20
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the YAML-to-JSON data-extension migration.
No open issues 🎉
What changed in this PR
Converts Unified’s data extensions from YAML to JSON to use faster loading supported by CodeQL CLI 2.27.3, while retaining YAML discovery for future contributions.
Changes:
- Migrates legacy Swift models to JSON without changing their tuples.
- Converts dataflow and model-as-data test extensions to JSON.
- Adds JSON model discovery alongside the existing YAML pattern.
| File | Description |
|---|---|
unified/ql/test/library-tests/mad/test.ext.yml |
Removes the replaced YAML test models. |
unified/ql/test/library-tests/mad/test.ext.json |
Preserves source and sink test models in JSON. |
unified/ql/test/library-tests/dataflow/test.ext.yml |
Removes the replaced YAML flow summaries. |
unified/ql/test/library-tests/dataflow/test.ext.json |
Preserves dataflow test summaries in JSON. |
unified/ql/lib/qlpack.yml |
Discovers both JSON and YAML model files. |
unified/ql/lib/ext/legacy-swift.model.yml |
Removes the replaced YAML Swift models. |
unified/ql/lib/ext/legacy-swift.model.json |
Carries forward Swift source, sink, and summary models in JSON. |
Review effort: Balanced (auto)
owen-mc
approved these changes
Nov 11, 2026
owen-mc
left a comment
owen-mc
left a comment
Contributor
There was a problem hiding this comment.
The described validation seems sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL CLI 2.27.3 supports JSON data extensions (aka MaD models), and can load them significantly faster than YAML. This PR converts those in the Unified library pack (first commit), along with
$TEST.ext.ymlfiles (second commit). The conversions were automated by an LLM-generated Python script (which I will add in a separate PR).Although JSON is preferred going forward,
unified/ql/lib/qlpack.ymlnow has patterns that will pick up both.model.ymland.model.jsonfiles, so that any YAML files that do get checked in won't get silently dropped.To verify successful conversion in the first commit, I cherry-picked it onto #23100, which has a temporary test that enumerates all tuples from data extensions. The test still passes after conversion.