Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The production-pack change lacks the requested DCA results and assessment of changed alerts or regressions, while the tuple-enumeration test does not provide equivalent real-database evidence.
1 open issue
What changed in this PR
Migrates Unified model-extension fixtures from YAML to JSON and adds coverage verifying preservation of all legacy source, sink, and summary model tuples.
Changes:
- Enables JSON model-extension discovery in the Unified library pack.
- Converts legacy Swift, MaD, and dataflow model extensions to JSON.
- Adds exhaustive model enumeration query results covering the converted tuples.
| File | Description |
|---|---|
| unified/ql/test/modelconversion/EnumerateModels.ql | Enumerates legacy source, sink, and summary model tuples for conversion verification. |
| unified/ql/test/modelconversion/EnumerateModels.expected | Records the expected complete set of enumerated model tuples. |
| unified/ql/test/modelconversion/Empty.swift | Provides the empty Swift fixture used by the model-conversion test. |
| unified/ql/test/library-tests/mad/test.ext.yml | Removes the YAML MaD test extension fixture in favor of its JSON representation. |
| unified/ql/test/library-tests/mad/test.ext.json | Provides the JSON MaD test extension fixture. |
| unified/ql/test/library-tests/dataflow/test.ext.yml | Removes the YAML dataflow test extension fixture in favor of its JSON representation. |
| unified/ql/test/library-tests/dataflow/test.ext.json | Provides the JSON dataflow test extension fixture. |
| unified/ql/lib/qlpack.yml | Enables loading JSON model extensions in the Unified library pack. |
| unified/ql/lib/ext/legacy-swift.model.yml | Removes the YAML legacy Swift model extension in favor of JSON. |
Review effort: Lite (auto)
| codeql/util: ${workspace} | ||
| dataExtensions: | ||
| - ext/*.model.yml | ||
| - ext/*.model.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.