Repository navigation
Conversation
`new URL(input, base)` only propagated taint from `input`.
A user-controlled `base` with a relative `input` decides the host of
the resulting URL, so it can reach a request sink but was missed.
Extend `isAdditionalRequestForgeryStep` to also propagate from the
second argument, for both the global `URL` and `require("url").URL`.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unconditional URL-base taint propagation causes false positives for absolute URLs, and negative regression tests plus an assessed DCA evaluation of the final change are still needed.
2 open issues
What changed in this PR
Extends JavaScript request-forgery analysis to track user-controlled URL bases, addressing the missed flows described in #23066.
Changes:
- Propagates taint from both arguments of global and Node.js-imported
URLconstructors. - Adds server-side regression cases and updates expected results.
- Documents the expanded server-side and client-side detection.
| File | Description |
|---|---|
javascript/ql/test/query-tests/Security/CWE-918/serverSide.js |
Adds base-argument cases for both constructor forms. |
javascript/ql/test/query-tests/Security/CWE-918/RequestForgery.expected |
Records new alerts and flow paths; adjusts shifted locations. |
javascript/ql/lib/semmle/javascript/security/dataflow/RequestForgeryCustomizations.qll |
Extends constructor taint propagation to argument 1. |
javascript/ql/lib/change-notes/2026-11-10-request-forgery-url-base.md |
Announces the request-forgery detection improvement. |
Review effort: Max (auto)
| exists(DataFlow::NewNode url | url = DataFlow::globalVarRef("URL").getAnInstantiation() | | ||
| succ = url and | ||
| pred = url.getArgument(0) | ||
| pred = url.getArgument([0, 1]) |
| exists(DataFlow::NewNode url | url = DataFlow::globalVarRef("URL").getAnInstantiation() | | ||
| succ = url and | ||
| pred = url.getArgument(0) | ||
| pred = url.getArgument([0, 1]) |
The base argument of `new URL(...)` is ignored when the first argument is already an absolute URL, either a string with a scheme or another `URL` object. Skip the base taint step in those cases.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new URL(input, base)only propagated taint frominput. A user-controlledbasewith a relativeinputdecides the host of the resulting URL, so it can reach a request sink but was missed.Extend
isAdditionalRequestForgeryStepto also propagate from the second argument, for both the globalURLandrequire("url").URL.Fixes #23066
Follows #5630, which added the first-argument step.