Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/identical-files.json
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,8 @@
"java/ql/lib/semmle/code/java/security/internal/EncryptionKeySizes.qll"
],
"Python model summaries test extension": [
"python/ql/test/library-tests/dataflow/model-summaries/InlineTaintTest.ext.yml",
"python/ql/test/library-tests/dataflow/model-summaries/NormalDataflowTest.ext.yml"
"python/ql/test/library-tests/dataflow/model-summaries/InlineTaintTest.ext.json",
"python/ql/test/library-tests/dataflow/model-summaries/NormalDataflowTest.ext.json"
],
"XML discard predicates": [
"javascript/ql/lib/semmle/javascript/internal/OverlayXml.qll",
Expand Down
15 changes: 15 additions & 0 deletions python/ql/lib/ext/default-threat-models-fixup.model.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"extensions": [
{
"addsTo": {
"pack": "codeql/threat-models",
"extensible": "threatModelConfiguration"
},
"data": [
// Since responses are enabled by default in the shared threat-models configuration,
// we need to disable it here to keep existing behavior for the python analysis.
["response", false, -2147483647]
]
}
]
}
8 changes: 0 additions & 8 deletions python/ql/lib/ext/default-threat-models-fixup.model.yml

This file was deleted.

2 changes: 2 additions & 0 deletions python/ql/lib/qlpack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,7 @@ dependencies:
dataExtensions:
- semmle/python/frameworks/**/*.model.yml
- ext/*.model.yml
- semmle/python/frameworks/**/*.model.json
- ext/*.model.json
Comment on lines +21 to +22
warnOnImplicitThis: true
compileForOverlayEval: true
13 changes: 13 additions & 0 deletions python/ql/lib/semmle/python/frameworks/AntiSSRF.model.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"extensions": [
{
"addsTo": {
"pack": "codeql/python-all",
"extensible": "barrierGuardModel"
},
"data": [
["AntiSSRF", "Member[URIValidator].Member[in_domain,in_azure_keyvault_domain,in_azure_storage_domain].Argument[0]", "true", "request-forgery"]
]
}
]
}
6 changes: 0 additions & 6 deletions python/ql/lib/semmle/python/frameworks/AntiSSRF.model.yml

This file was deleted.

39 changes: 39 additions & 0 deletions python/ql/lib/semmle/python/frameworks/Asyncpg.model.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"extensions": [
{
"addsTo": {
"pack": "codeql/python-all",
"extensible": "sinkModel"
},
"data": [
// `Connection`s and `ConnectionPool`s provide some methods that execute SQL.
["asyncpg.~Connection", "Member[copy_from_query,execute,fetch,fetchrow,fetchval].Argument[0,query:]", "sql-injection"],
["asyncpg.~Connection", "Member[executemany].Argument[0,command:]", "sql-injection"],
// A model of `Connection` and `ConnectionPool`, which provide some methods that access the file system.
["asyncpg.~Connection", "Member[copy_from_query,copy_from_table].Argument[output:]", "path-injection"],
["asyncpg.~Connection", "Member[copy_to_table].Argument[source:]", "path-injection"],
// the `PreparedStatement` class in `asyncpg`.
["asyncpg.Connection", "Member[prepare].Argument[0,query:]", "sql-injection"]
]
},
{
"addsTo": {
"pack": "codeql/python-all",
"extensible": "typeModel"
},
"data": [
// a `ConnectionPool` that is created when the result of `asyncpg.create_pool()` is awaited.
["asyncpg.Connection", "asyncpg.ConnectionPool", "Member[acquire].ReturnValue.Awaited"],
// a `Connection` that is created when
// * - the result of `asyncpg.connect()` is awaited.
// * - the result of calling `acquire` on a `ConnectionPool` is awaited.
["asyncpg.Connection", "asyncpg", "Member[connect].ReturnValue.Awaited"],
["asyncpg.Connection", "asyncpg", "Member[connection].Member[connect].ReturnValue.Awaited"],
["asyncpg.ConnectionPool", "asyncpg", "Member[create_pool].ReturnValue.Awaited"],
// Creating an internal `~Connection` type that contains both `Connection` and `ConnectionPool`.
["asyncpg.~Connection", "asyncpg.Connection", ""],
["asyncpg.~Connection", "asyncpg.ConnectionPool", ""]
]
}
]
}
29 changes: 0 additions & 29 deletions python/ql/lib/semmle/python/frameworks/Asyncpg.model.yml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"extensions": [
{
"addsTo": {
"pack": "codeql/python-all",
"extensible": "sinkModel"
},
"data": [
["azure.keyvault.certificates.CertificateClient!", "Call.Argument[0,vault_url:]", "request-forgery"],
["azure.keyvault.certificates.DeletedCertificate!", "Call.Argument[recovery_id:]", "request-forgery"],
["azure.keyvault.keys.KeyClient!", "Call.Argument[0,vault_url:]", "request-forgery"],
["azure.keyvault.secrets.SecretClient!", "Call.Argument[0,vault_url:]", "request-forgery"]
]
}
]
}

This file was deleted.

41 changes: 41 additions & 0 deletions python/ql/lib/semmle/python/frameworks/Azure.Storage.model.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
{
"extensions": [
{
"addsTo": {
"pack": "codeql/python-all",
"extensible": "sinkModel"
},
"data": [
["azure.storage.blob.BlobClient!", "Call.Argument[0,account_url:]", "request-forgery"],
["azure.storage.blob.BlobClient", "Member[append_block_from_url].Argument[0,copy_source_url:]", "request-forgery"],
["azure.storage.blob.BlobClient", "Member[get_page_range_diff_for_managed_disk].Argument[0,previous_snapshot_url:]", "request-forgery"],
["azure.storage.blob.BlobClient", "Member[stage_block_from_url].Argument[1,source_url:]", "request-forgery"],
["azure.storage.blob.BlobClient", "Member[start_copy_from_url].Argument[0,source_url:]", "request-forgery"],
["azure.storage.blob.BlobClient", "Member[upload_blob_from_url].Argument[0,source_url:]", "request-forgery"],
["azure.storage.blob.BlobClient", "Member[upload_pages_from_url].Argument[0,source_url:]", "request-forgery"],
["azure.storage.blob.BlobClient!", "Member[from_blob_url].Argument[0,blob_url:]", "request-forgery"],
["azure.storage.blob.BlobServiceClient!", "Call.Argument[0,account_url:]", "request-forgery"],
["azure.storage.blob.ContainerClient!", "Call.Argument[0,account_url:]", "request-forgery"],
["azure.storage.blob.ContainerClient!", "Member[from_container_url].Argument[0,container_url:]", "request-forgery"],
["azure", "Member[storage].Member[blob].Member[download_blob_from_url].Argument[0,blob_url:]", "request-forgery"],
["azure", "Member[storage].Member[blob].Member[upload_blob_to_url].Argument[0,blob_url:]", "request-forgery"],
["azure.storage.filedatalake.DataLakeDirectoryClient!", "Call.Argument[0,account_url:]", "request-forgery"],
["azure.storage.filedatalake.DataLakeFileClient!", "Call.Argument[0,account_url:]", "request-forgery"],
["azure.storage.filedatalake.DataLakeServiceClient!", "Call.Argument[0,account_url:]", "request-forgery"],
["azure.storage.filedatalake.FileSystemClient!", "Call.Argument[0,account_url:]", "request-forgery"],
["azure.storage.fileshare.ShareClient!", "Call.Argument[0,account_url:]", "request-forgery"],
["azure.storage.fileshare.ShareClient!", "Member[from_share_url].Argument[0,share_url:]", "request-forgery"],
["azure.storage.fileshare.ShareDirectoryClient!", "Call.Argument[0,account_url:]", "request-forgery"],
["azure.storage.fileshare.ShareDirectoryClient!", "Member[from_directory_url].Argument[0,directory_url:]", "request-forgery"],
["azure.storage.fileshare.ShareFileClient!", "Call.Argument[0,account_url:]", "request-forgery"],
["azure.storage.fileshare.ShareFileClient!", "Member[from_file_url].Argument[0,file_url:]", "request-forgery"],
["azure.storage.fileshare.ShareFileClient", "Member[start_copy_from_url].Argument[0,source_url:]", "request-forgery"],
["azure.storage.fileshare.ShareFileClient", "Member[upload_range_from_url].Argument[0,source_url:]", "request-forgery"],
["azure.storage.fileshare.ShareServiceClient!", "Call.Argument[0,account_url:]", "request-forgery"],
["azure.storage.queue.QueueClient!", "Call.Argument[0,account_url:]", "request-forgery"],
["azure.storage.queue.QueueClient", "Member[from_queue_url].Argument[0,queue_url:]", "request-forgery"],
["azure.storage.queue.QueueServiceClient!", "Call.Argument[0,account_url:]", "request-forgery"]
]
}
]
}
34 changes: 0 additions & 34 deletions python/ql/lib/semmle/python/frameworks/Azure.Storage.model.yml

This file was deleted.

13 changes: 13 additions & 0 deletions python/ql/lib/semmle/python/frameworks/Django.model.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"extensions": [
{
"addsTo": {
"pack": "codeql/python-all",
"extensible": "barrierGuardModel"
},
"data": [
["django", "Member[utils].Member[http].Member[url_has_allowed_host_and_scheme].Argument[0,url:]", "true", "url-redirection"]
]
}
]
}
6 changes: 0 additions & 6 deletions python/ql/lib/semmle/python/frameworks/Django.model.yml

This file was deleted.

16 changes: 16 additions & 0 deletions python/ql/lib/semmle/python/frameworks/Eventlet.model.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"extensions": [
{
"addsTo": {
"pack": "codeql/python-all",
"extensible": "typeModel"
},
"data": [
// See https://eventlet.readthedocs.io/en/latest/patching.html
["socket.socket", "eventlet", "Member[green].Member[socket].Member[socket].ReturnValue"],
// eventlet also re-exports as eventlet.socket for convenience
["socket.socket", "eventlet", "Member[socket].Member[socket].ReturnValue"]
]
}
]
}
9 changes: 0 additions & 9 deletions python/ql/lib/semmle/python/frameworks/Eventlet.model.yml

This file was deleted.

14 changes: 14 additions & 0 deletions python/ql/lib/semmle/python/frameworks/Gevent.model.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"extensions": [
{
"addsTo": {
"pack": "codeql/python-all",
"extensible": "typeModel"
},
"data": [
// See https://www.gevent.org/api/gevent.socket.html
["socket.socket", "gevent", "Member[socket].Member[socket].ReturnValue"]
]
}
]
}
7 changes: 0 additions & 7 deletions python/ql/lib/semmle/python/frameworks/Gevent.model.yml

This file was deleted.

Loading
Loading