Skip to content

Dataflow: Allow a config access path limit above the language default. #23049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschackmull merged 2 commits into from
Nov 10, 2026
Merged

Dataflow: Allow a config access path limit above the language default. #23049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e79ec4b
Dataflow: Use the config rather than the language default ap limit.
aschackmull Nov 9, 2026
d4875b8
Dataflow: Allow a config ap limit above the language default.
aschackmull Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,15 +566,15 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {

pragma[nomagic]
private int getAnApLengthLowerBound(Ap ap) {
accessPathLimit() != 0 and // `accessPathLimit() = 0` is already checked in `useFieldFlow`
Config::accessPathLimit() != 0 and // `accessPathLimit() = 0` is already checked in `useFieldFlow`
result = ap.length()
or
not exists(ap.length()) and
exists(Ap tail |
fwdFlowConsCand(_, ap, _, _, tail) and
ap != tail and // no need to report a longer length
result = 1 + getAnApLengthLowerBound(tail) and
result <= accessPathLimit()
result <= Config::accessPathLimit()
)
}

Expand Down Expand Up @@ -612,7 +612,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
fwdFlowStore(_, _, ap0, _, c, t, stored, node, cc, summaryCtx) and
ap = apCons(c, ap0) and
apa = getApprox(ap) and
getAnApLengthLowerBound(ap0) < accessPathLimit()
getAnApLengthLowerBound(ap0) < Config::accessPathLimit()
)
or
// read
Expand Down Expand Up @@ -1340,15 +1340,15 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {

pragma[nomagic]
private int getAnApLengthLowerBoundRev(Ap ap) {
accessPathLimit() != 0 and // `accessPathLimit() = 0` is already checked in `useFieldFlow`
Config::accessPathLimit() != 0 and // `accessPathLimit() = 0` is already checked in `useFieldFlow`
result = ap.length()
or
not exists(ap.length()) and
exists(Ap tail |
revFlowConsCand(ap, _, tail) and
ap != tail and // no need to report a longer length
result = 1 + getAnApLengthLowerBoundRev(tail) and
result <= accessPathLimit()
result <= Config::accessPathLimit()
)
}

Expand Down Expand Up @@ -1389,7 +1389,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
exists(Nd mid, Ap ap0 |
revFlow(mid, returnCtx, returnAp, ap0) and
readStepFwd(node, ap, _, mid, ap0) and
getAnApLengthLowerBoundRev(ap0) < accessPathLimit()
getAnApLengthLowerBoundRev(ap0) < Config::accessPathLimit()
)
or
// flow into a callable
Expand Down
11 changes: 9 additions & 2 deletions shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1794,15 +1794,22 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
TReturnCtxNoFlowThrough() or
TReturnCtxMaybeFlowThrough(ReturnPosition pos)

/**
* Gets the upper bound for the access path length limit that is supported
* in data flow Configurations. This is set to be at least twice the
* language default access path limit.
*/
private int accessPathLimitConfigCap() { result = 10.maximum(2 * accessPathLimit()) }

cached
newtype TAccessPathFront =
TFrontNil() or
TFrontHead(Content c, int length) { length in [1 .. accessPathLimit()] }
TFrontHead(Content c, int length) { length in [1 .. accessPathLimitConfigCap()] }
Comment thread
aschackmull marked this conversation as resolved.
Resolved

cached
newtype TApproxAccessPathFront =
TApproxFrontNil() or
TApproxFrontHead(ContentApprox c, int length) { length in [1 .. accessPathLimit()] }
TApproxFrontHead(ContentApprox c, int length) { length in [1 .. accessPathLimitConfigCap()] }

cached
newtype TAccessPathFrontOption =
Expand Down
Loading