Repository navigation
Dataflow: Allow a config access path limit above the language default. - #23049
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The existing default-limit test does not cover the restored above-default behavior or configuration-specific boundaries, including lower-limit and new-cap cases.
1 open issue
What changed in this PR
This PR addresses the above-default access-path limit regression introduced by #22392, allowing custom data-flow configurations to track longer paths while retaining a configuration-independent upper bound.
Changes:
- Raises the cached access-path length cap to the greater of 10 or twice the language default.
- Uses the configured limit in forward and reverse access-path length checks.
| File | Description |
|---|---|
shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll |
Expands exact and approximate access-path front domains using the new cap. |
shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll |
Applies configuration-specific limits to forward and reverse flow checks. |
Review effort: Balanced (auto)
hvitved
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent performance improvement in data flow (#22392) accidentally introduced an upper bound of the supported access path limit values in configurations equal to the language default access path limit.
While the performance improvement necessitates an up-front configuration-independent upper bound, we might as well bump that a bit, so configurations can opt to increase the limit if so desired.
See also the reported issues #23041 and #23042.