Skip to content

C#: Harden cs/useless-cast-to-self with respect to unknown types. #22393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelnebel merged 2 commits into from
Aug 20, 2026
+5 −0
Merged

C#: Harden cs/useless-cast-to-self with respect to unknown types. #22393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63e54b4
C#: Harden cs/useless-cast-to-self for BMN extracted databases.
michaelnebel Aug 20, 2026
97985c8
C#: Add change-note.
michaelnebel Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions csharp/ql/src/Language Abuse/UselessCastToSelf.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@ where
type = cast.getTargetType() and
type = e.getType() and
not type instanceof NullType and
not type instanceof UnknownType and
not e.(ImplicitDelegateCreation).getArgument() instanceof AnonymousFunctionExpr
select cast, "This cast is redundant because the expression already has type " + type + "."
4 changes: 4 additions & 0 deletions csharp/ql/src/change-notes/2026-08-20-harden-useless-cast-to-self.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: fix
---
* The query `cs/useless-cast-to-self` no longer reports casts when both the expression type and the cast target type are unknown, which can occur in `build-mode: none` databases.
Loading