Go: migrate control flow graph to shared CFG library #2 - #22182

Open

owen-mc wants to merge 71 commits into

github:mainfrom

owen-mc:go/shared-cfg

Commits on Sep 15, 2026

Align old CFG node strings with shared library
owen-mc
committed
a0dc0d2
Improve redundant recover test coverage
owen-mc
committed
2daa7ed
More tests for non-returning functions
owen-mc
committed
b82db67
Test semantic invalid types in notype test
owen-mc
committed
62f2b42
Make KeyValueExpr have the same type as its value
owen-mc
committed
9c749eb
Change mayReturnNormally to mustNotReturnNormally
owen-mc
committed
2200bfa
Distinguish panic and exit in logrus
owen-mc
committed
af19ef3
Model `logrus.Exit` like `os.Exit`
owen-mc
committed
304ec85
Update two queries so alert locations don't change
owen-mc
committed
a772b42
Make synthetic RangeElementExpr during extraction
owen-mc
committed
171046a
Switch to using shared CFG library
owen-mc
committed
1f64f10
Add go/print-cfg
owen-mc
committed
30a0488
Add Go CFG consistency query
owen-mc
committed
e7000ab
fold implicit-one operand into incdec-rhs instruction
owen-mc
committed
0bd998f
fold compound-assign write into the compound-rhs instruction
owen-mc
committed
dee1d8c
drop implicit slice-bound nodes
owen-mc
committed
2c77287
Merge 'result-init' node into 'result-zero-init'
owen-mc
committed
16b2eaa
Fold implicit literal element index into the lit-init node
owen-mc
committed
16b9560
Fold uninitialised var-decl zero-init and write into one node
owen-mc
committed
5383fe8
Fold tuple-destructuring extract and write into one node
owen-mc
committed
857f549
Unify result-zero-init and zero-init node kinds
owen-mc
committed
00815e9
Simplify zero-init code after unifying result-zero-init
owen-mc
committed
cf6bf47
Unify incdec-rhs into the compound-rhs node kind
owen-mc
committed
8f90962
No CFG nodes for subexprs of const exprs
owen-mc
committed
59c5534
Add change note
owen-mc
committed
9b523f2
Replace IfStmt.getCond with IfStmt.getCondition
owen-mc
committed
6df8595
Address review comments
owen-mc
committed
864e10a
Add defer CFG edge-case tests
owen-mc
committed
b66ccd8
Build defer edges from an early Go CFG
owen-mc
committed
b815f92
Model Go function epilogues in the body CFG
owen-mc
committed
290fa45
Address more review comments
owen-mc
committed
85fb77e
Change CompoundAssignStmt and IncDecStmt
owen-mc
committed
f344944
Move `getExpr` to `SwitchExpr`
owen-mc
committed
6e48157
Remove/reduce comments
owen-mc
committed
f37db60
Rename file to ControlFlowGraphImpl.qll
owen-mc
committed
7e48a1e
Use american spelling
owen-mc
committed
cfe78ef
Add missing qldoc
owen-mc
committed
c2d6703
Update change note
owen-mc
committed
c9276a0
Fix non-US spelling
owen-mc
committed
b0427e0
Change function epilogue CFG
owen-mc
committed
187e3fd
Remove CFG hook by making CFG for SelectStmt simpler
owen-mc
committed
65cffd7
Remove CFG hook preservesDefaultControlFlow
owen-mc
committed
b93595e
Allow empty switch to be a simple leaf node
owen-mc
committed
563fae2
Rename ForeachStmt to ForEachStmt
owen-mc
committed
d3298c7
Undo unnecessary code changes
owen-mc
committed
0593055
Skip extracting ast.ParenExpr nodes

owen-mc
and
Copilot
committed
ff260f5
Deprecate ParenExpr and remove all references

owen-mc
and
Copilot
committed
82c2fd1
Accept `invalidAbruptCompletionOrigin` results
owen-mc
committed
17033d8
Fix `invalidAbruptCompletionOrigin` results
owen-mc
committed
f76a0e4
Restore data flow through pointer assignment targets
owen-mc
committed
2c36cb9
Fix go/whitespace-contradicts-precendence for ParenExpr removal
owen-mc
committed
c236b40
Fix bad join order
owen-mc
committed
3d9f2f3
(Performance) don't materialize ancestor relation
owen-mc
committed
79724e7
(Performance) speed up GVN calculations by using contracted graph
owen-mc
committed
2dd2c2d
Shared CFG: Add `includeCallableEntry` hook
owen-mc
committed
eaf952d
Performance: Use `includeCallableEntry` hook
owen-mc
committed
948c032
Minor refactor (don't use AstNode.getNumChild)
owen-mc
committed
f49ab92
Refactor: avoid transitive closures
owen-mc
committed
c5bd6ab
Limit Go build-constraint regex matching to initial comments
owen-mc
committed
c875d32
Fix bad join order
owen-mc
committed
1728570
Cache Go CFG root lookup
owen-mc
committed
e6bbfb2
Use shared CFG leaf representation more for Go
owen-mc
committed
aea3d94
Use shared default sequencing for ordinary Go operations
owen-mc
committed
00b3005
Use shared CFG leaf nodes for Go function literals
owen-mc
committed
efc650b
Add QLDoc to `skipCfg`
owen-mc
committed
54329d6
Cache Go IR write-target construction
owen-mc
committed
48479b1
Limit Go explicit CFG child ranking to its consumers
owen-mc
committed
02a6899
Remove unnecessary `Instruction.getRoot` overrides
owen-mc
committed
861446c
Cache `getEnclosingCallable`
owen-mc
committed
69ed945
Single node for function, import, type decls
owen-mc
committed
85f0fb5
Add missing QLDoc in shared library
owen-mc
committed
6727aba